Comments on: Refactoring Code: A Programmers Challenge http://www.thycotic.com/refactoring-code-a-programmers-challenge Fri, 12 Mar 2010 13:21:47 -0500 http://wordpress.org/?v=2.8.3 hourly 1 By: Maxim’s blog » links for 2009-04-12 http://www.thycotic.com/refactoring-code-a-programmers-challenge/comment-page-1#comment-3814 Maxim’s blog » links for 2009-04-12 Sun, 12 Apr 2009 07:01:23 +0000 http://www.thycotic.com/?p=341#comment-3814 [...] Refactoring Code: A Programmer’s Challenge [...] [...] Refactoring Code: A Programmer’s Challenge [...]

]]> By: Kevin Jones http://www.thycotic.com/refactoring-code-a-programmers-challenge/comment-page-1#comment-3811 Kevin Jones Mon, 06 Apr 2009 15:32:15 +0000 http://www.thycotic.com/?p=341#comment-3811 @Adam - Yes this is going to be a series. We'll keep taking refactoring a step further in every post. The next one should come out this coming Thursday. @Adam – Yes this is going to be a series. We’ll keep taking refactoring a step further in every post. The next one should come out this coming Thursday.

]]> By: Adam Stadola http://www.thycotic.com/refactoring-code-a-programmers-challenge/comment-page-1#comment-3810 Adam Stadola Fri, 03 Apr 2009 22:15:55 +0000 http://www.thycotic.com/?p=341#comment-3810 @aa: I think you missed the point of Kevin's post. The point wasn't about WHERE to put the logic, but how to extract it and test it. Now that he put it in a separate class, he can easily unit test it. And for what it's worth, AppSettings are really meant to be used as something configurable without needing a re-compile, say like on a production site. It doesn't seem like this kind of data needs to be easily configurable. @Kevin, I am interested in where this is going. Is this going to be a series? A refactoring series would be sweet. @aa: I think you missed the point of Kevin’s post. The point wasn’t about WHERE to put the logic, but how to extract it and test it. Now that he put it in a separate class, he can easily unit test it.

And for what it’s worth, AppSettings are really meant to be used as something configurable without needing a re-compile, say like on a production site. It doesn’t seem like this kind of data needs to be easily configurable.

@Kevin, I am interested in where this is going. Is this going to be a series? A refactoring series would be sweet.

]]> By: aa http://www.thycotic.com/refactoring-code-a-programmers-challenge/comment-page-1#comment-3809 aa Fri, 03 Apr 2009 16:20:01 +0000 http://www.thycotic.com/?p=341#comment-3809 I would have put the list of pages in AppSettings and use a function to add the appsettings key-pair in an array/generic list. I would have put the list of pages in AppSettings and use a function to add the appsettings key-pair in an array/generic list.

]]>